Skip to content

Refactor retrieving 404 Sketch #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Refactor retrieving 404 Sketch #3195

merged 3 commits into from
Jul 19, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Jul 19, 2024

Changes:

  • Refactors fetching the 404 page sketch in server/views/404Page.js to use async/await syntax. Will eventually need to be overall changed to render on the client side.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Jul 19, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-63efb0bfc8

@raclim raclim merged commit dc54e34 into develop Jul 19, 2024
4 checks passed
@raclim raclim deleted the light-404sketch branch July 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant