Skip to content

The repeat check for New Password is performed only when entered #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

The repeat check for New Password is performed only when entered #3194

merged 2 commits into from
Jul 19, 2024

Conversation

shibomb
Copy link
Contributor

@shibomb shibomb commented Jul 18, 2024

Fixes #3193

Changes:
The repeat check for New Password is performed only when New Password is entered.
This would make the current password less mandatory and allow the email change logic to work.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

shibomb and others added 2 commits July 18, 2024 18:11
@shibomb
The repeat check for New Password is performed only when New Password…
34384b7 
… is entered.

This would make the current password less mandatory and allow the email change logic to work.
fix processing#3193
@raclim
Merge branch 'develop' into fix/passwordrepeatcheck-when-enternewpass…
2ec5c10 
…word
raclim
raclim approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this, this must've been broken for a while! 😅 This should be live on production by sometime early next week!

@raclim raclim merged commit ca58abd into processing:develop Jul 19, 2024
1 check passed
@shibomb shibomb deleted the fix/passwordrepeatcheck-when-enternewpassword branch July 20, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot change user email.
2 participants
@shibomb @raclim