Skip to content

Update Collections with Mongoose Upgrade #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Jul 12, 2024

Changes:

  • refactor listCollections() to async/await
  • update typo in removeProjectFromCollection.js
  • update collection and project models setup to match mongoose 6.13.0 (addresses errors with loading and updating collections)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Jul 12, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-6b808a3051

@raclim raclim merged commit edcd351 into develop Jul 12, 2024
4 checks passed
@raclim raclim deleted the mongoose-collections-update branch July 12, 2024 18:30
}

return next();
next();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make a difference that we changed this from return next() to just next()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants