Skip to content

Address warnings #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2024
Merged

Address warnings #3183

merged 3 commits into from
Jul 8, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Jul 8, 2024 •
edited
Loading

Changes:

  • removes SASS warnings when using division
  • removes required prop-type warning in routes.jsx
  • adds aria labels to LoginForm.jsx and SignupForm.jsx and corrects semantic html for the containers of the label and input fields

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim merged commit c7927f7 into develop Jul 8, 2024
3 checks passed
@raclim raclim deleted the address-warnings branch July 8, 2024 16:34
@release-com release-com
Copy link

release-com bot commented Jul 8, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-4f956f0d8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raclim