Skip to content

fix signup & login input width #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix signup & login input width #3176

merged 1 commit into from
Jun 25, 2024

Conversation

shujuuu
Copy link
Collaborator

@shujuuu shujuuu commented Jun 25, 2024

Fixes #3158

Changes:

  • Fix the input fields' width for mobile
  • Did a small refactor to the password input fields so the eye icon placement is dynamic
Login Signup
S__13336589 S__13336593

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@shujuuu shujuuu requested a review from lindapaiste June 25, 2024 13:15
raclim
raclim approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me! Thanks so much for working on this @shujuuu!

@raclim raclim merged commit b0168f1 into processing:develop Jun 25, 2024
3 checks passed
@raclim raclim mentioned this pull request Jun 25, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

@lindapaiste lindapaiste Awaiting requested review from lindapaiste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signup & login pages are cropped on both side
2 participants
@shujuuu @raclim