Skip to content

Fix broken file name tabs in mobile #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

shujuuu
Copy link
Collaborator

@shujuuu shujuuu commented Jun 14, 2024

Fixes #3157

Changes:
Specifying the React fragment as a div fixed the issue.
Also changed the tab's bg color so it looks like an active tab.

Screenshot 2024-06-14 at 12 52 29 AM

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jun 14, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@shujuuu shujuuu requested a review from lindapaiste June 14, 2024 05:55
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this issue and working on this! I realized it might've originated from this PR (https://github.com/processing/p5.js-web-editor/pull/3130/files). It overall seems good to me, so I'm going to merge this in!

@raclim raclim merged commit 02aa981 into processing:develop Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile version file name layout is broken
2 participants