Skip to content

Updated esversion to 11 from 7 to fix warnings related to nullish assingment #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Chaitanya1672
Copy link
Contributor

Fixes #3146

Changes:
I have updated esversion from 7 to 11 to resolve warnings related to nullish assignment.
I have Updated Editor/index.js to set the CodeMirror instance with the updated esversion.

Before:-
image

After:-
image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching and fixing this, this is great!

@raclim raclim merged commit 9836f4d into processing:develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lines with a nullish coalescing assignment flags an error
2 participants