Skip to content

Fix timeout errors #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix timeout errors #3099

merged 2 commits into from
Apr 26, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Apr 26, 2024

Progress towards #3096

Changes:

  • Removes optional callback from findByEmailOrUsername() from server/models/user.js and temporarily ignoring the case sensitivity option that determines which database call to return, since where it's currently being used doesn't seem to have any major effects for now. This definitely needs to be revisited, but just seeing if this will temporarily mitigate the current issue for now.
  • Adds try/catch blocks and more error handling for copying objects from s3 in server/controllers/aws.controller.js and for sending mail in server/utils/mail.js

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Apr 26, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-deee40720a

@raclim raclim merged commit 1053155 into release Apr 26, 2024
4 checks passed
@raclim raclim deleted the fix/timeout-errors branch May 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant