Skip to content

Continue to Address Outage Issues #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Continue to Address Outage Issues #3097

merged 7 commits into from
Apr 25, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Apr 24, 2024

Progress towards #3096

Changes:

  • In server/models/user.js, if the user object doesn't have a password property, thecomparePassword() method will return a boolean value and console logs error instead of throwing it. This is probably a temporary solution—currently I'm testing if this will remove the errors popping up. Why this is being called initially still needs to be identified.
  • Optional chaining operators are added to objects in the server/controllers/aws.controller.js to address errors where properties are undefined.
  • More defined status codes are added togetSession() in server/controllers/session.controller.js to hopefully remove 404 errors every time a user without an account is on the platform. 200 is sent only when there is a user without an account, which should prevent authenticateUser() from being called. There's probably a better way to do this, but seeing if this will work for now.
  • validateSession() in client/modules/User/actions.js is also refactored to use async/await syntax

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Apr 24, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-fbc140f915

@raclim raclim merged commit 31d4ded into release Apr 25, 2024
4 checks passed
@raclim raclim deleted the fix/address-outage-issues branch April 26, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant