Continue to Address Outage Issues #3097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #3096
Changes:
server/models/user.js
, if the user object doesn't have a password property, thecomparePassword()
method will return a boolean value and console logs error instead of throwing it. This is probably a temporary solution—currently I'm testing if this will remove the errors popping up. Why this is being called initially still needs to be identified.server/controllers/aws.controller.js
to address errors where properties are undefined.getSession()
inserver/controllers/session.controller.js
to hopefully remove404
errors every time a user without an account is on the platform.200
is sent only when there is a user without an account, which should preventauthenticateUser()
from being called. There's probably a better way to do this, but seeing if this will work for now.validateSession()
inclient/modules/User/actions.js
is also refactored to useasync/await
syntaxI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123