Skip to content

Address Undefined Arguments Error in comparePassword #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Apr 23, 2024

Addresses Server Log (pictured below) that identifies undefined arguments being passed to the comparePassword() method in the user model.

Screenshot 2024-04-23 at 2 27 16 PM

Changes:

  • Checks if this.password exists before calling bcrypt.compare
  • Adds explicit try/catch and error messaging

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Apr 23, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-b09a8aa84a

@raclim raclim merged commit abe1927 into release Apr 23, 2024
4 checks passed
@raclim raclim deleted the fix/undefined-password branch April 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant