fixes #2221 characters getting deleted between file changes #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
raclim
added
Priority:Medium
…editor into fixes-processing#2221/random-character-getting-deleted
…haracter-getting-deleted
… of https://github.com/Chaitanya1672/p5.js-web-editor into fixes-processing#2221/random-character-getting-deleted
…editor into fixes-processing#2221/random-character-getting-deleted
…editor into fixes-processing#2221/random-character-getting-deleted
raclim
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2221
Hi @raclim please merge this fix.
Changes: The error occurred due to the Emmet feature within the Emmetio plugin. Emmetio attempted to apply markTagPairs on JavaScript code files, leading to code deletion wherever an underlined character was present. Additionally, this deletion occurred whenever the user clicked enter. So, I have added the condition to disable that feature for JavaScript files.
I have verified that this pull request:
npm run test)developbranch.Fixes #2221MarkTagPairs use :-
Issue fixed video:-
Random.characters.getting.deleted.fixed.mp4