Skip to content

Deepan190703/fix .mtl #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Conversation

deepan190703
Copy link
Contributor

@deepan190703 deepan190703 commented Mar 27, 2024

Fixes #3067

Changes:
Allowing .mtl file uploads in the p5.js Web Editor would ensure feature consistency between the editor and p5.js itself, reducing potential confusion for users.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes Enable .mtl File Uploads #3067

@raclim raclim added Enhancement Improvement to an existing feature Area:Editor For CodeMirror-related features labels Mar 27, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I think this looks pretty good so far!

I think one additional change I would make is adding '.mtl' to where the different file formats are mentioned in the translations/locales files. Here's a screenshot of those files below, and I'm going to link the specific line in the english translations for reference too.
Screenshot 2024-03-27 at 7 25 27 PM

I think it should be fine as is, but I might also double check if the '.mtl' file needs a specific file mode besides 'text/plain' for the getFileMode() function in the Editor/index.js file.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding in the translations!

I think besides the comment I left in the index.js file, it would be best to remove the changes in the package.json and package-lock.json file—ideally we don't want any changes to these files.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added in one minor change that resets the package-lock.json file to mirror the one in the main branch, but overall I think this is great! Thanks for working on this and for your contribution!

@raclim raclim merged commit e11f56a into processing:develop Mar 28, 2024
@raclim raclim added this to the MINOR Release for 2.13.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Editor For CodeMirror-related features Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable .mtl File Uploads
2 participants