Skip to content

Fixed Passport handles expected errors as exceptions #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

letscodedanish
Copy link
Contributor

Fix account suspension handling in authentication strategies

Fixes #3044

Changes

  • Addressed the issue regarding the handling of account suspension messages in the authentication strategies, specifically for GitHub and Google authentication.

Checklist

  • No linting errors (npm run lint)
  • No test errors (npm run test)
  • Created from a uniquely-named feature branch (fix-account-suspension-handling) and is up to date with the develop branch.
  • Descriptively named and links to the corresponding issue number, i.e., Fixes #3044

Additional Details

Ensured that when a user is banned, the authentication process fails gracefully with an appropriate account suspension message. This enhances the security and user experience of the authentication flow.

This pull request aims to improve the reliability and security of the application by providing clear feedback to users with suspended accounts during the authentication process.

lindapaiste
lindapaiste previously approved these changes Feb 24, 2024
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

letscodedanish and others added 2 commits February 24, 2024 11:16
…xpected_errors' into fixed/Passport_handles_expected_errors

# Conflicts:
#	server/config/passport.js
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to run the lint-fix command for Prettier to reformat 2 lines.

@lindapaiste lindapaiste merged commit 8980fe5 into processing:develop Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passport handles expected errors as exceptions
2 participants