Skip to content

Added Missing ending quotation mark to "Added to [collection]" toast #3021 #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

aditya3011ai
Copy link
Contributor

@aditya3011ai aditya3011ai commented Feb 15, 2024

Added Missing ending quotation mark to "Added to [collection]" toast #3021

Changes:

I've noticed that some Toast messages were also missing closing quotation marks. In this pull request, I've addressed this issue by adding the necessary closing quotation marks to ensure consistency in collections.js
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Feb 15, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@aditya3011ai aditya3011ai changed the title Fixed #3021 Added Missing ending quotation mark to "Added to [collection]" toast #3021 Feb 15, 2024
@lindapaiste lindapaiste linked an issue Feb 19, 2024 that may be closed by this pull request
@lindapaiste
Copy link
Collaborator

Thanks! This is definitely an improvement so I'm merging this in now and we can address the translations at a later date.

@lindapaiste lindapaiste merged commit 38ba23f into processing:develop Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ending quotation mark to "Added to [collection]" toast
2 participants