Implemented Toast Notifications for Error Handling During User Settings Update #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
reviewed
Jan 28, 2024
| submitSettings(formValues) | ||
| .then((response) => { | ||
| dispatch(updateSettingsSuccess(response.data)); | ||
| dispatch(showToast(5500)); | ||
| dispatch(setToastText('Toast.SettingsSaved')); | ||
| resolve(); | ||
| }) | ||
| .catch((error) => resolve({ error })) | ||
| ); | ||
| .catch((error) => { |
There was a problem hiding this comment.
I wonder if we can look here and check if it's specifically a 401 error so that we know it's an incorrect password. If it's a 500 we could show a generic "something went wrong". We could also think about using the message from the server which plays into a larger discussion on translating server-side messages.
There was a problem hiding this comment.
Yes, that sounds like a good approach. Differentiating between specific HTTP status codes like :
- 401 for incorrect passwords
- 500 for generic errors
On it
4 tasks
raclim
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2965
Added toast notification for error handling when users update their settings, addressing scenarios of
Empty Current Password FieldandIncorrect Current Password.Changes:
Screen.Recording.2024-01-28.at.10.14.57.PM.mov
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #2965