fixed scroll

[rahulrangers]

Fixes #2905

Changes:

@lindapaiste I have verified that this pull request:

Untitled.video.-.Made.with.Clipchamp.1.mp4

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

[PiyushChandra17]

👍

[raclim]

Sorry about that, after taking a closer look I realized I didn't carefully look at which particular files were being changed! I think this PR is still good for review!

[raclim]

Thanks again for your work on this and I apologize for closing this earlier! After testing this out I think this looks good to go!

[lindapaiste]

@raclim the min-height: 100vh which was removed in this PR was previously put in to prevent jumpiness on the desktop view when the fetch for the .md file finishes and the content comes in. Setting min-height: 100vh forces the scrollbar to be present at all times so that it won't disappear and reappear. You can find the issues. IMO we want to keep that when on desktop, but apply it conditionally using a media query. That's what I meant by my suggestion (emphasis added)

There's probably a few valid ways to fix this, with differences in what content is fixed to the top. One way would be in the PolicyContainer. We would add an overflow: auto and remove the min-height: 100vh; when in the mobile view.

[raclim]

@lindapaiste Ohh I see, sorry I did notice the distinction for only the mobile view but didn't realize the reasoning behind it and assumed it seemed okay. I'll reopen the issue and can update this PR with the needed changes!

[beccyabraham]

It looks like those pages still don't scroll all the way down on mobile; on the Privacy Policy page, I can't see the "Contact information" section