Skip to content

Fixes Clicking on cross icon on create folder/create file modal throws unnessary error. #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iamnithishraja
Copy link
Contributor

@iamnithishraja iamnithishraja commented Jan 16, 2024

Fixes #2895

Changes:
Clicking on cross icon or whitespace on create folder/create file modal not dosen't throw any validation error message, instead throws only when submit button is pressed.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #2895

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good at first glance. I need to run the branch to interact with it and verify everything.

I envisioned that we would look at a submitted property on the form, but surprisingly they don't have that property. Checking for clicks on the submit button is a smart way around that.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! I think this looks okay for now, so I'm going to get this in!

@raclim raclim merged commit ed79707 into processing:develop Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on cross icon on create folder/create file modal throws validation error message for a while
3 participants