Skip to content

Saving unsaved Sketch before signing in with Oauth. #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

vivekbopaliya
Copy link
Contributor

Fixes #2334

Changes:
Props to @lindapaiste , he/she figured out how to sort this out while I just stuck two pieces together :)
#2424 (comment)

bandicam.2024-01-13.14-29-38-628.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added the Enhancement Improvement to an existing feature label Jan 14, 2024
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I had not tried out my proposed fix to see if it actually works. You've tried it out and verified it so now it seems good to go 👍. Thanks!

@lindapaiste lindapaiste merged commit b28f347 into processing:develop Jan 14, 2024
@raclim raclim added this to the MINOR Release for 2.11.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign-in with oauth requires page reload
3 participants