Fix Button with display="inline"
to use the same styles as the regular button
#2822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2821
This does not change any UI anywhere in the app. It removes some unused code and enables us to use the
<Button>
component inline in the future. There is more that could be refactored and cleaned up but I'm keeping this PR minimal.Changes:
StyledButton
component to use eitherdisplay: inline-flex
ordisplay: flex
, depending on the value of thedisplay
prop.StyledIconButton
component which was not used anywhere. Confusingly, the existingIconButton
component which we use on mobile is an extension of theStyledInlineButton
rather than theStyledIconButton
.IconButton
component by passing down the propiconOnly
and using this prop to switch components rather than switching based on thedisplay
prop.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123