Skip to content

fix: #2730 The navbar menu is now responsive #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

aryanas159
Copy link
Contributor

@aryanas159 aryanas159 commented Dec 16, 2023

Fixes #2730

Changes:
Made some style changes to the mobile nav menu container, added max widths and heights and allowed auto overflow for scrolling in case the modal overflows on smaller screens.
I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
Untitled.video.-.Made.with.Clipchamp.5.mp4

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I just tested this out and it seems to work for me. Since this impedes the mobile experience I'm going to merge this in and deploy it right after.

@raclim raclim merged commit 105ad12 into processing:develop Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ellipsis modal is not responsive on mWeb
2 participants