Skip to content

Changed arrow color on ConsoleInput #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Typicalcodes
Copy link
Contributor

Fixes #2721

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e.

@lindapaiste
Copy link
Collaborator

Looking at your changes I can see that we have an existing theme variable console-active-arrow-color specifically for this element. But it was not being applied because we were only targeting path and this SVG uses polygon[1]. You fixed that 👍. How does it look if we use your change in the targeting (& g, & polygon, & path {) but leave the color variable like it was before? Better or worse?

[1] This sort of thing is a frequent problem throughout the app. At some point in the future I would really like to overhaul how we recolor SVGs so that we only need to target the <svg> element, and the SVG file would use currentColor to pass down that color.

@lindapaiste lindapaiste changed the title Changed arrow style Changed arrow color on ConsoleInput Dec 15, 2023
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@Sudarshan-21 Sudarshan-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working fine and looks great too, but dont you think changing color to something similar to the 'console-header-color' would be more impressive.

@raclim raclim added Bug Error or unexpected behaviors Area:CSS For styling or layout issues handled with CSS/SASS labels Jan 26, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, I think this is great for now!

@raclim raclim merged commit c1b3f7c into processing:develop Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Bug Error or unexpected behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consoleinput arrow is not Adjusting to changed theme.
5 participants