fix: #2719 Shortcuts Ctrl + Shift + 1 and Ctrl + Shift + 2 aren't wor…

[aryanas159]

…king.

Fixes #2719
Changes:
Added a mapping for '!' -> 1, '@' -> 2, because due to the shift key Ctrl + Shift + 1 was being registered as Ctrl + Shift + !, which wasn't triggering the event.
I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

Untitled.video.-.Made.with.Clipchamp.2.mp4

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

[lindapaiste]

Great catch on the problem! 🧤

The KeyboardEvent interface's key read-only property returns the value of the key pressed by the user, taking into consideration the state of modifier keys such as Shift as well as the keyboard locale and layout.

I wonder if there's a better way to handle this which doesn't involve manual mapping. Like if there is a property other than e.key which we can look at. It seems like maybe e.code would work?

The KeyboardEvent.code property represents a physical key on the keyboard (as opposed to the character generated by pressing the key). In other words, this property returns a value that isn't altered by keyboard layout or the state of the modifier keys

I also want to look into how CodeMirror handles their keymaps, and maybe we can copy something from their source code.

[aryanas159]

Great idea @lindapaiste e.code works well, I have pushed the changes.
Also, I checked out the CodeMirror repo and it doesn't seem like they have a keymapping for ctrl+shift+{any number}.

[aryanas159]

Hey, @lindapaiste could you please review the changes?

[raclim]

Thanks for your work on this!