-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Promotion for 2023 Fundraiser #2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-4f9da8ab92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
The images/video look good but the text in the header won’t show up at all on the mobile version. We should think about how we can integrate it there. If the git stuff is worth fixing then you can check out the release branch and then cherry-pick these commits onto it. Pick them from this branch you created onto some other branch off of release. You’d have to create a new PR though. |
Thanks for pointing out the mobile version! I had it in mind but ultimately forgot about it at some point 😅 I'm not sure where the text in the header would fit in the layout. Maybe a direct link to it could be placed in the dropdown menu? I'll try some stuff out and update this PR with the mobile changes. Hmm for the git stuff, looking through the commits I feel like there might be a good number of them that might need to be cherry-picked. I'm thinking it might be okay to forgo it this time, but I'm also open to going through with it if there's a strong preference for it. |
There's a lot of changes here, but I'm going to try to get this out for today's fundraiser launch! Thanks again everyone for your input, and please let me know know if anyone has any further suggestions! |
Fixes #2713
Overall Changes
About.jsx
.translations/locales/en-US/translations.json
.FundraiserSection()
toclient/modules/IDE/components/Header/Nav.jsx
.client/styles/components/_nav.scss
.client/modules/IDE/components/Header/MobileNav.jsx
.client/modules/IDE/components/Header/__snapshots__/Nav.unit.test.jsx.snap
.FundraiserModal.jsx
toclient/modules/IDE/components
. This is also added toIDEOVerlays.jsx
client/images
.client/styles/abstracts/_variables.scss
,client/styles/components/_fundraiser.scss
, andclient/styles/main.scss
.Other Notes
release
branch so these updates could be deployed separately from the ones in the MINOR release. I realized near the end though that I ended up working off ofdevelop
😭, so the next MINOR release will also probably be when this is deployed. The next one will probably be around the week of 01/08, since PF will be closed on 12/25-01/05.What it Looks Like
fundraiser_draft_2.mov
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123