Skip to content

Add Promotion for 2023 Fundraiser #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 15, 2023
Merged

Add Promotion for 2023 Fundraiser #2714

merged 18 commits into from
Dec 15, 2023

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Dec 13, 2023

Fixes #2713

Overall Changes

  • 'Donate' link added to About.jsx.
  • Fundraiser text added to translations/locales/en-US/translations.json.
  • Link in Nav to Open a Fundraiser Modal
    • Adds FundraiserSection() to client/modules/IDE/components/Header/Nav.jsx.
    • Updates Styling in client/styles/components/_nav.scss.
    • Responsiveness added to client/modules/IDE/components/Header/MobileNav.jsx.
    • Updates Snapshots in client/modules/IDE/components/Header/__snapshots__/Nav.unit.test.jsx.snap.
  • Fundraiser Modal
    • Adds FundraiserModal.jsx to client/modules/IDE/components. This is also added to IDEOVerlays.jsx
    • Adds Actions, Constants, and Reducers to open and close the Fundraiser Modal.
    • Adds the Processing Foundation logo to client/images.
    • Adds Styling in client/styles/abstracts/_variables.scss, client/styles/components/_fundraiser.scss, and client/styles/main.scss.

Other Notes

  • The changes in this PR are intended to be temporary, and will be reverted once the fundraiser is over.
  • This PR is should be merged by 12/15, which is the fundraiser's launch date. It's a bit soon, so open to making any needed updates even if they are given after this date!
  • This PR may change as I continue to receive feedback on the design.
  • I initially intended to work off of the release branch so these updates could be deployed separately from the ones in the MINOR release. I realized near the end though that I ended up working off of develop 😭, so the next MINOR release will also probably be when this is deployed. The next one will probably be around the week of 01/08, since PF will be closed on 12/25-01/05.

What it Looks Like

Screenshot of Fundraiser Link in the Navigation Screenshot of Opened Fundraiser Modal
fundraiser_draft_2.mov

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim requested a review from lindapaiste December 13, 2023 00:59
@raclim raclim changed the title Feature/fundraiser content Add Promotion for 2023 Fundraiser Dec 13, 2023
Copy link

release-com bot commented Dec 13, 2023

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-4f9da8ab92

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lindapaiste
Copy link
Collaborator

The images/video look good but the text in the header won’t show up at all on the mobile version. We should think about how we can integrate it there.

If the git stuff is worth fixing then you can check out the release branch and then cherry-pick these commits onto it. Pick them from this branch you created onto some other branch off of release. You’d have to create a new PR though.

@raclim
Copy link
Collaborator Author

raclim commented Dec 14, 2023

Thanks for pointing out the mobile version! I had it in mind but ultimately forgot about it at some point 😅 I'm not sure where the text in the header would fit in the layout. Maybe a direct link to it could be placed in the dropdown menu? I'll try some stuff out and update this PR with the mobile changes.

Hmm for the git stuff, looking through the commits I feel like there might be a good number of them that might need to be cherry-picked. I'm thinking it might be okay to forgo it this time, but I'm also open to going through with it if there's a strong preference for it.

@raclim
Copy link
Collaborator Author

raclim commented Dec 15, 2023

I just added in the mobile elements (screenshots of it are below)! I moved the original header text into the navigational dropdown menu, which ended up widening it quite a bit. I don't think this greatly affects anything, but I'm not sure if this implementing these kinds of changes should be avoided.

Screenshot of Navigation for Mobile Version Screenshot of Fundraiser Banner in the Mobile Version
mobile_fundraiser.mov

@raclim
Copy link
Collaborator Author

raclim commented Dec 15, 2023

There's a lot of changes here, but I'm going to try to get this out for today's fundraiser launch! Thanks again everyone for your input, and please let me know know if anyone has any further suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Content to Promote 2023 PF Fundraiser
3 participants