Skip to content

Update public_api.md (changes made) #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Update public_api.md (changes made) #2712

merged 4 commits into from
Dec 27, 2023

Conversation

soniyaprasad77
Copy link
Contributor

@soniyaprasad77 soniyaprasad77 commented Dec 11, 2023

Fixes #1769

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Dec 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done 👍

@raclim raclim added this to the PATCH Release for 2.10.1 milestone Dec 15, 2023
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this, this is great so far!

I think one change that I feel would make more sense is for the added section "Enabling Access Token UI in Settings Page" to be higher up in the document, such as in between the sections "Models" and "Sketch".

@soniyaprasad77 soniyaprasad77 changed the title Update public_api.md Update public_api.md (changes made) Dec 15, 2023
@soniyaprasad77
Copy link
Contributor Author

Thanks so much for working on this, this is great so far!

I think one change that I feel would make more sense is for the added section "Enabling Access Token UI in Settings Page" to be higher up in the document, such as in between the sections "Models" and "Sketch".

Did some changes, is it good to go?

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@raclim raclim merged commit 41529a3 into processing:develop Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update public_api.md in developer_docs to set UI_ACCESS_TOKEN_ENABLED=true
3 participants