Skip to content

Fixes #2653, No Validation for sketch file rename #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

gauravsingh94
Copy link
Contributor

Fixes #2653

Changes:
Fixed validation for sketch file rename now it take only 100 characters as input.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@gauravsingh94 gauravsingh94 changed the title Issue #2653 Fixed issue-#2653 No Validation for sketch file rename Nov 30, 2023
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. We would want 128 characters instead of 100 because that is what we use in other places.

I’ve discussed some other considerations in a comment on the issue: #2653 (comment)

@gauravsingh94
Copy link
Contributor Author

Output

Screencast.from.2023-12-01.14-30-41.webm

@gauravsingh94
Copy link
Contributor Author

@lindapaiste I've incorporated the modifications you recommended and introduced some additional CSS to maintain the integrity of the website design.
Could you please share your feedback on these changes?

@raclim raclim added the Enhancement Improvement to an existing feature label Jan 26, 2024
@raclim raclim changed the title Fixed issue-#2653 No Validation for sketch file rename Fixes #2653, No Validation for sketch file rename Jan 26, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! I personally found adding in the maxLength and the overflow-wrap to be visually okay for now and updated this PR with these changes. However, if it seems like it might need a few more changes I think that can be added later on as well.

@raclim raclim merged commit f7cdeca into processing:develop Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Validation for sketch file rename
3 participants