-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fixes #2653, No Validation for sketch file rename #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. We would want 128 characters instead of 100 because that is what we use in other places.
I’ve discussed some other considerations in a comment on the issue: #2653 (comment)
Output Screencast.from.2023-12-01.14-30-41.webm |
@lindapaiste I've incorporated the modifications you recommended and introduced some additional CSS to maintain the integrity of the website design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! I personally found adding in the maxLength
and the overflow-wrap
to be visually okay for now and updated this PR with these changes. However, if it seems like it might need a few more changes I think that can be added later on as well.
Fixes #2653
Changes:
Fixed validation for sketch file rename now it take only 100 characters as input.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123