Skip to content

Fix bug where clicking "File > New" doesn't open a new sketch #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Fix bug where clicking "File > New" doesn't open a new sketch #2590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67700ad
Remove `setTimeout`
lindapaiste Nov 10, 2023
681040d
Merge branch 'develop' into fix/file-new
lindapaiste Nov 10, 2023
531d4db
Merge branch 'develop' into fix/file-new
raclim Nov 10, 2023
f9b1268
Prevent double alert.
lindapaiste Nov 11, 2023
3850b69
Merge remote-tracking branch 'origin/fix/file-new' into fix/file-new
lindapaiste Nov 11, 2023
e64680e
Merge branch 'develop' into fix/file-new
raclim Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent double alert.
  • Loading branch information
@lindapaiste
lindapaiste committed Nov 11, 2023
commit f9b12686297a8ea86a322a680b3c891d05bccaf1
2 changes: 1 addition & 1 deletion client/modules/IDE/actions/project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export function resetProject() {
}

export function newProject() {
browserHistory.push('/');
browserHistory.push('/', { confirmed: true });
return resetProject();
}

Expand Down
3 changes: 2 additions & 1 deletion client/modules/IDE/pages/IDEView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ function WarnIfUnsavedChanges() {
isAuth(nextLocation.pathname) ||
isAuth(currentLocation.pathname) ||
isOverlay(nextLocation.pathname) ||
isOverlay(currentLocation.pathname)
isOverlay(currentLocation.pathname) ||
nextLocation.state?.confirmed
) {
return true; // allow navigation
}
Expand Down