Skip to content

Cleaned the codebase by removing unused files inside client/component… #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2024
Merged

Cleaned the codebase by removing unused files inside client/component… #2561

merged 3 commits into from
Jun 3, 2024

Conversation

yashpandey06
Copy link
Contributor

Fixes #2555

Changes:

I have removed some unused files under client/components/Nav to make the codebase look more organised

  • [Yes] has no linting errors (npm run lint)
  • [ Yes] has no test errors (npm run test)
  • [ Yes] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [ Yes] is descriptively named and links to an issue number, i.e. Fixes #123

@welcome Welcome
Copy link

welcome bot commented Nov 2, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 23, 2024
@raclim raclim added Area: Code Quality For refactoring, cleanup, or improvements to maintainability Enhancement Improvement to an existing feature labels Jan 26, 2024
raclim
raclim approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! :) I also removed the translations associated with the removed components, AddRemoveButton.jsx and MobileIDEView.jsx as well.

@raclim raclim merged commit aaefbcd into processing:develop Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
Area: Code Quality For refactoring, cleanup, or improvements to maintainability Enhancement Improvement to an existing feature
Projects
None yet
Milestone
MINOR Release 2.14.0
Development

Successfully merging this pull request may close these issues.

Cleaning of codebase by removing unused components in client folder .
2 participants
@yashpandey06 @raclim