Update the S3/AWS client package #2246 #2443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
reviewed
Sep 15, 2023
| } else { | ||
| fullObjectKey = objectKey; | ||
| } | ||
| const fullObjectKey = userId ? `${userId}/${objectKey}` : objectKey; |
There was a problem hiding this comment.
So much cleaner with the ternary!
|
Thanks for working on this! At first glance it looks great but I do need to give it a more careful review. |
|
sure, go ahead 🚀🚀 |
raclim
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Thanks for your work on this!
I ran this locally and also created a Release build for this update, and they both felt good to me so far. I'm going to merge this in, but I'll also continue to manually test the develop branch for the next few days, so feel free to make any additional suggestions or comments.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2246
Changes:
@aws-sdk/client-s3packageI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123