Skip to content

Refactor DashboardView.jsx : Applied Necessary changes required [Ref PR#2422] #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Akshay02022
Copy link
Contributor

@Akshay02022 Akshay02022 commented Sep 14, 2023

Issue Ref #2358

Changes: Removed useEffect and unused arguments.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I added an additional commit to your branch where I went ahead and used the hooks for react-router etc. because we don't need to rely on HOCs and props anymore now that it's a function component.

@lindapaiste lindapaiste merged commit 185a0b1 into processing:develop Nov 18, 2023
@raclim raclim added this to the PATCH Release for 2.9.3 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants