Skip to content

Jest styled components #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

dewanshDT
Copy link
Collaborator

Changes:
added the jest-styled-components

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss thank you!

@raclim We don't love this solution because it requires us to update the snapshots whenever we change the styles. Ideally we would ignore the styles and just look at the HTML. It's definitely an improvement because it gives us stable class names and ensures that these snapshots won't fail due to changes elsewhere.

@lindapaiste lindapaiste merged commit c7492d3 into processing:develop Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants