Skip to content

Fix #2336: CookieConsent cannot be hidden properly on very small screens #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2336

Changes:

  • The change in position is based on the height of the element rather than a fixed amount.
  • bottom is always 0.
  • The change now comes from a transform translateY.
  • I used 105% instead of 100% because I was paranoid that the top 1px of the banner might sometimes be visible due to rounding errors if the banner starts exactly below where the screen ends. Not sure if this is an actual issue but I figured it's better to be safe. 🤷

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added Priority:Low Low-impact issue that can be addressed after higher-priority tasks Area: Mobile For issues affecting mobile or responsive behavior labels Aug 2, 2023
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@raclim raclim merged commit e7914d7 into processing:develop Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Mobile For issues affecting mobile or responsive behavior Priority:Low Low-impact issue that can be addressed after higher-priority tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CookieConsent cannot be hidden properly on very small screens
3 participants