Skip to content

Fix #2314 by ignoring deleted assets in zip download #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2314

Changes:

  • catch errors fetching files from AWS and include an empty 0KB file instead.
  • Simplify addFileToZip by converting to async/await syntax.
  • Use the return value of .folder() rather than manually concatenating paths.

I'm not sure if how I'm handing deleted files is the best way. It seemed like the best among the options that I considered. We can skip over missing files entirely. I also toyed with putting a text file (ie. image_png.txt) with the contents "File Not Found".

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added the Bug Error or unexpected behaviors label Jul 28, 2023
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raclim raclim added this to the MINOR Release for 2.12.0 milestone Jan 19, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors
Projects
No open projects
Status: PRs to Review
Development

Successfully merging this pull request may close these issues.

p5 Editor not allowing duplication or download of one specific sketch
3 participants