Fix #2314 by ignoring deleted assets in zip download #2315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2314
Changes:
catch
errors fetching files from AWS and include an empty 0KB file instead.addFileToZip
by converting toasync
/await
syntax..folder()
rather than manually concatenating paths.I'm not sure if how I'm handing deleted files is the best way. It seemed like the best among the options that I considered. We can skip over missing files entirely. I also toyed with putting a text file (ie.
image_png.txt
) with the contents "File Not Found".I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123