Convert APIKeyForm
to a function component and connect to Redux
#2307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a
//TODO
and also fixes a mistake that I made in the existing code for theAccountView
. I should be passing through arguments to the action creators on thosedispatch
calls. As a result of that mistake, theApiKeyForm
doesn't work. Which is fine because the feature flagUI_ACCESS_TOKEN_ENABLED
isfalse
so we never show the form. But we should fix it.p5.js-web-editor/client/modules/User/pages/AccountView.jsx
Lines 105 to 111 in 3493b3b
Changes:
AccountView
.APIKeyForm
to a function component.APIKeyForm
manages its own Redux state withuseSelector
anduseDispatch
.It looks like a lot more changes when viewing the diff due to the changed indentation level.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123