Skip to content

Update createDefaultFiles.js to reflect p5.js version 1.7.0 #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

SableRaf
Copy link
Contributor

@SableRaf SableRaf commented Jul 11, 2023

Fixes #issue-number

Changes: Updates the p5.js version to 1.7.0

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@SableRaf SableRaf requested a review from raclim July 11, 2023 17:32
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this! Going to loop @Qianqianye here as well :)

@raclim raclim merged commit 32d5bdc into processing:develop Jul 11, 2023
@SableRaf
Copy link
Contributor Author

No problem! I made the changes live on Twitch so it provided educational value too 😄

Thanks @lindapaiste for consolidating all the files so only defaultHTML in createDefaultFiles.js needs to be updated!

@Qianqianye
Copy link
Collaborator

Thanks @SableRaf and @raclim. I just double checked the version at web editor page, and it seems like that the version is not updated yet.

@raclim
Copy link
Collaborator

raclim commented Jul 11, 2023

I haven't deployed these updates to production yet, since I'm still testing the mirror I replaced the missing console-feed package with. I'll keep you all posted when it's live, which should definitely be sometime this week!

@raclim
Copy link
Collaborator

raclim commented Jul 14, 2023

@Qianqianye Just deployed the editor, which should reflect the new p5.js version!! I'll probably update the p5.js version for the Examples too by next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants