Skip to content

Fix #2278 keyboard shortcut for tidy code shows replace #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2278

Changes:

  • Handle the keyboard event for Shift-Ctrl-F using the CodeMirror 'extraKeys' option rather than a keydown event handler. CodeMirror will only execute one action per key (unless the handler returns CodeMirror.Pass) so this prevents the Ctrl-F action from being executed when Shift is pressed.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste requested a review from raclim July 6, 2023 23:02
@lindapaiste
Copy link
Collaborator Author

Build is failing due to console-feed getting removed from npm. They are trying to get it back but I don't know when that will happen: samdenty/console-feed#124

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me, thanks for working on this!

We're also keeping track of the missing console-feed package, and will probably hold off on merging/deploying for now until it's resolved!

@raclim raclim merged commit dd2f731 into processing:develop Jul 11, 2023
@lindapaiste lindapaiste deleted the fix/tidy-code branch August 8, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcut for "Tidy code" shows "Replace"
2 participants