Skip to content

Revoke outdated Blob URLs #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

lindapaiste
Copy link
Collaborator

Partial fix for #2234

This revokes the Blob URL which is assigned to the preview HTML document. I have not addressed the additional Blob URLs which are assigned to individual .js files as that's more complicated.

Changes:

  • EmbedFrame component stores its last-created Blob URL in a ref (srcRef).
  • It revokes the previous URL whenever it creates a new one.
  • I put the revocation inside the existing setTimeout to be safe, so that there is no chance of seeing a momentary flash of expired content.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste requested a review from raclim June 8, 2023 02:14
@raclim raclim added this to the MINOR Release for 2.13.0 milestone Mar 8, 2024
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!!! I'm now wondering if there are any specific scenarios where folks are utilizing both the old and new blobs for their projects 😂 but this is definitely better to address!

@raclim raclim merged commit 740203b into processing:develop Mar 29, 2024
@raclim raclim moved this from Reviewing in Progress to Done in PR Review Board May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants