Simplify repetitive form code #2231
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
In forms which use
react-final-form
we have a lot of repeated boilerplate. For example every field has the same error code:Changes:
FormField
for aninput
with alabel
and an optional error message.FinalFormField
which uses theForm
component from thereact-final-form
package and passes the props from the generatedfield
down to theFormField
UI.FinalFormField
component in forms:AccountForm
LoginForm
ResetPasswordForm
SignupForm
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123