prefer react-i18next useTranslation
hook
#2045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
t
function fromreact-i18next
viaconst { t } = useTranslation();
rather than thewithTranslation
HOC or by passing it down from a parent.EditorAccessibility
ErrorModal
, andShareModal
from class components to function components as they didn't use any lifecycle methods, so the conversion is trivial.I'm not sure if it's better to do refactoring on a "one change at a time" basis like this, or a "one component at a time" basis. The advantages of "one change at a time" is that it avoids versioning issues for dependencies such as
react-router
which need to be updated before we can use hooks.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123