Skip to content

Add releases and semantic versioning, re: #1421 #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

catarak
Copy link
Member

@catarak catarak commented May 21, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixes #1421.

@catarak
Copy link
Member Author

catarak commented May 21, 2020

In conjunction with this PR, we will need to

  • Create a release branch
  • Create a develop branch
  • Change the default branch to develop
  • Create a v1.0.0 tag, and confirm it gets deployed correctly to Travis CI/DockerHub/GKE

@catarak catarak requested review from andrewn and ghalestrilo May 21, 2020 21:48
Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! 👍

@catarak catarak changed the base branch from master to develop May 26, 2020 18:35
@catarak catarak merged commit da51c6b into develop May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic Versioning and Releases
2 participants