Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Error message is not being Translated to selected Language #3229

Open
Ganeshvarikuppala opened this issue Sep 7, 2024 · 4 comments · May be fixed by #3249
Open

The Error message is not being Translated to selected Language #3229

Ganeshvarikuppala opened this issue Sep 7, 2024 · 4 comments · May be fixed by #3249
Labels

Comments

@Ganeshvarikuppala
Copy link

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

It is not getting translated
Pj5

Expected Behavior

It should be translated

Steps to reproduce

Steps:

  1. Go to Sign Up page
    2.Select language
    3.Enter the invalid inputs
    4.You will get a error message displayed.
    5.Now select another language.
    6.Everything will be translated except Error message
Copy link

welcome bot commented Sep 7, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@Serena20003
Copy link
Contributor

Serena20003 commented Sep 8, 2024

Hi, I think the issue here is that because the error message gets re-populated only after the user has "touched" the input field, which means that they need to enter the text field, then leave the text field for the error message to re-populate.
This can be seen in line 79 of client/modules/User/components/SignupForm.js: {field.meta.touched && field.meta.error && (
Perhaps one way to work around it is to change field.meta.touched to something else that doesn't require the user to enter and leave the textfield again after changing the language (perhaps field.meta.invalid?).
The number of translations on translations/locales/hi/translations.json match the number on translations/locales/hi/translations.json for ReduxFormUtils, which I believe is controlling the translations for error messages for the signup form fields.
I did notice one missing translation for "This username is already taken." though.
Screenshot 2024-09-08 at 2 25 46 PM

@AbhigyanSrivastav
Copy link

Hey can i work on this issue?

@Sankalpcreat
Copy link

is it still open

AbhigyanSrivastav added a commit to AbhigyanSrivastav/p5.js-web-editor that referenced this issue Oct 16, 2024
@AbhigyanSrivastav AbhigyanSrivastav linked a pull request Oct 16, 2024 that will close this issue
4 tasks
AbhigyanSrivastav added a commit to AbhigyanSrivastav/p5.js-web-editor that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants