Skip to content

Commit

Permalink
Restores default link target as '#'.
Browse files Browse the repository at this point in the history
Empty <a> tags negatively affect the SEO score (as measured by Chrome's Lighthouse plugin).
  • Loading branch information
bocytko committed Dec 21, 2022
1 parent c2aa088 commit 5982675
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions docs/radar.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,8 @@ function radar_visualization(config) {
.data(segmented[quadrant][ring])
.enter()
.append("a")
// Add an href if (and only if) there is a link
.attr("href", function (d, i) {
return d.link ? d.link : null;
return d.link ? d.link : "#"; // stay on same page if no link was provided
})
// Add a target if (and only if) there is a link and we want new tabs
.attr("target", function (d, i) {
Expand Down

0 comments on commit 5982675

Please sign in to comment.