Skip to content

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 27, 2020

Previous implementation was only designed to work on Windows OS

  • the actual destination path was the concatenation of the provided destination path + the path of the parent of the source svg file. But it removed the first 2 letters from the parent source path (probably to manage the Windows drive)
  • In addition, it put the whole path lower case, replace space by underscore, probably to work on old Windows versions that don't like space and mix cases when using the Command Prompt

On Linux (and probably all case-sensitive OS, so MacOS), this changed the destination folder a lot which made it very hard to find the generated file.

Changes done in this area in the upstream repo (commits ordered by date) and that have been integrated into develop on 2020-08-16

  • 2020-06-22
    • "Changed stencil group naming mechanism to be more intuitive" jgraph@f0d2f73
  • 2020-06-24
    • "Fixes group name generating and option for naming from config ": jgraph@b9058ba
    • "Less folders are generated at destination ": jgraph@1f232f5

There was still an issue because the path was still put into lower-case that has been fixed.
Several tests have been added to verify that the generation works on all OS.

@tbouffard tbouffard added the bug Something isn't working label Apr 27, 2020
@tbouffard tbouffard force-pushed the fix/svg2xml_destination_path_on_linux branch from bafed34 to bd5afe1 Compare April 28, 2020 10:32
@tbouffard tbouffard force-pushed the fix/svg2xml_destination_path_on_linux branch from bd5afe1 to d71d96b Compare June 1, 2020 22:52
@tbouffard tbouffard changed the title WIP Fix path where files are generated WIP svg2xml: fix actual destination path of generated files Jun 1, 2020
@tbouffard tbouffard force-pushed the fix/svg2xml_destination_path_on_linux branch from 2ed576c to 152b94d Compare June 4, 2020 00:05
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2020

CLA assistant check
All committers have signed the CLA.

@tbouffard tbouffard force-pushed the fix/svg2xml_destination_path_on_linux branch 2 times, most recently from 0c4004e to 892d2ac Compare August 16, 2020 19:46
Do not lowercase the generation output path.
Several tests have been added to verify that the generation works on all OS.
@tbouffard tbouffard force-pushed the fix/svg2xml_destination_path_on_linux branch from 892d2ac to 2bbff8a Compare August 16, 2020 19:50
@tbouffard tbouffard changed the title WIP svg2xml: fix actual destination path of generated files [svg2xml] fix actual destination path of generated files Aug 16, 2020
@tbouffard tbouffard marked this pull request as ready for review August 16, 2020 19:52
@tbouffard tbouffard changed the title [svg2xml] fix actual destination path of generated files [svg2xml] fix destination path of generated files Aug 16, 2020
@tbouffard tbouffard merged commit 4c49307 into develop Aug 16, 2020
@tbouffard tbouffard deleted the fix/svg2xml_destination_path_on_linux branch August 16, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tool:svg2xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants