[TEST] Bump Jest dependencies to use version 28 #2320

tbouffard · 2022-10-25T05:36:27Z

Add jest-environment-jsdom dependency: as of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.

Locally fix jest-playwright-preset@2.0.0 types with patch-package. This is a temporary solution until a new release including the fix is available.

Update the typescript-support test configuration to prevent the types used to develop bpmn-visualization from being part of the type resolution in the test project:

We don't want to test them (we only want to ensure types resolution is OK when bpmn-visualization is included in a project/application.
The previous configuration generates errors because some types needed at development time require a newer TypeScript version than the one supported by bpmn-visualization. For instance, jest@28 types requires TS 4.3 and typescript-support runs with TS 4.0
To do this, override the typeRoots configuration which included by default all development types (available in ../../node_modules)

closes #2004

Tests done

✔️ Run all tests locally including performance tests
✔️ Checking locally the e2e tests report by introducing an arbitrary error: screenshots created and attached to the report
✔️ Performance tests compilation is currently failing. Use patch-package (see PR description) until TypeScript Build Failure: global.d.ts(233,5): error TS2709: Cannot use namespace 'JestConfig' as a type. playwright-community/jest-playwright#808 is fixed
- The patch was created by first updating locally the node_modules/jest-playwright-preset/types/global.d.ts file (use types that are fixed in the main branch)
- Then, run npx patch-package jest-playwright-preset to create the patch file and edit it to remove extra file permissions
✔️ typescript-support tests are failing. Investigated by activating "traceResolution": true and reviewing https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#overview
- existing configuration: ts-support_TS_4.0.2_config_01_typeRoots_default.txt
- updated typeRoots configuration: ts-support_TS_4.0.2_config_02_typeRoots_unset.txt
✔️ coverage report. coverage-reports.zip
✔️ test reports: in particular, the extended report of e2e tests including snapshots. e2e-reports.zip

github-actions · 2022-10-25T05:37:29Z

♻️ PR Preview 3ccd089 has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

github-actions · 2022-10-25T05:37:40Z

♻️ PR Preview 3ccd089 has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

test/integration/helpers/html-utils.ts

tbouffard · 2022-10-25T08:40:17Z

❌ performance tests compilation is currently failing

Same errors if we run tsc on e2e tests 👇🏿

$ tsc -p test/e2e/
node_modules/@jest/test-result/build/index.d.ts:11:23 - error TS2307:
Cannot find module 'jest-haste-map' or its corresponding type declarations.

11 import type {FS} from 'jest-haste-map';
                         ~~~~~~~~~~~~~~~~

node_modules/@jest/test-result/build/index.d.ts:12:30 - error TS2307:
Cannot find module 'jest-haste-map' or its corresponding type declarations.

12 import type {ModuleMap} from 'jest-haste-map';
                                ~~~~~~~~~~~~~~~~

node_modules/jest-playwright-preset/types/global.d.ts:233:5 - error TS2709:
Cannot use namespace 'JestConfig' as a type.

233   | JestConfig
        ~~~~~~~~~~


Found 3 errors in 2 files.

Errors  Files
     2  node_modules/@jest/test-result/build/index.d.ts:11
     1  node_modules/jest-playwright-preset/types/global.d.ts:23

tbouffard · 2022-10-25T14:49:33Z

ℹ️ I have just tested with jest@29 and the same problems occur (perf test compilation errors + foreignObject CSS selector).

Add `jest-environment-jsdom` dependency: as of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.

tbouffard · 2022-11-06T18:13:45Z

Current issue with Performance tests compilation

This also occurs if we run tsc with bundles and e2e tests as the issue is in jest-playwright types

node_modules/jest-playwright-preset/types/global.d.ts:233:5 - error TS2709: Cannot use namespace 'JestConfig' as a type.

233   | JestConfig

Root cause is playwright-community/jest-playwright#808
Possible workaround: use skipLibCheck=true in the tsconfig.json file used to compile the performance tests, but this will prevent to detect other issues in other dependencies.

…son at project root)

# Conflicts: # package-lock.json # package.json

This is a temporary solution until a new release including the fix is available.

# Conflicts: # package-lock.json # package.json

csouchet · 2022-11-15T13:22:50Z

test/helpers/query-selectors.ts

-    return `${this.labelSvgGroup(bpmnElementId)} > g > foreignObject > div > div > div`;
+    // * is for 'foreignObject'
+    // Using 'foreignObject' do not work anymore with jest@28 (jsdom bump for 16.6 to 19)
+    return `${this.labelSvgGroup(bpmnElementId)} > g > * > div > div > div`;


Good catch 👍🏻

csouchet

Very good job. Thank you for this updating and the investigation 🎉

sonarqubecloud · 2022-11-15T13:34:21Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

tbouffard added help wanted Extra attention is needed chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) labels Oct 25, 2022

tbouffard commented Oct 25, 2022

View reviewed changes

test/integration/helpers/html-utils.ts Outdated Show resolved Hide resolved

tbouffard added 3 commits November 6, 2022 18:50

[TEST] Bump Jest dependencies to use version 28

6a44367

Add `jest-environment-jsdom` dependency: as of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.

restore usage of 'bpmnQuerySelectors.labelLastDiv'

8256c59

update package-lock.json

7a7537b

tbouffard added 2 commits November 6, 2022 19:24

update jest config: remove extra files in 'roots'

dfb26b1

README: simplify command to run test in the "Contributing" paragraph

90b321d

tbouffard force-pushed the test/bump_jest_v28 branch from 1b0fc3c to 90b321d Compare November 6, 2022 18:25

tbouffard added 7 commits November 6, 2022 19:28

remove extra tsconfig.json file in e2e tests (use the tsconfig.test.j…

6f6cf87

…son at project root)

Merge branch 'master' into test/bump_jest_v28

fe60669

# Conflicts: # package-lock.json # package.json

update package-lock.json after merge

d6b480c

Locally fix jest-playwright-preset types with patch-package

b82be0f

This is a temporary solution until a new release including the fix is available.

GH action: run script with npm ci

c1d776d

Fix typescript-support tests

910d3cb

Merge branch 'master' into test/bump_jest_v28

bbd803b

# Conflicts: # package-lock.json # package.json

tbouffard marked this pull request as ready for review November 15, 2022 06:08

tbouffard requested a review from csouchet November 15, 2022 06:09

tbouffard removed the help wanted Extra attention is needed label Nov 15, 2022

csouchet reviewed Nov 15, 2022

View reviewed changes

csouchet approved these changes Nov 15, 2022

View reviewed changes

Merge branch 'master' into test/bump_jest_v28

3ccd089

tbouffard merged commit 0a82ed9 into master Nov 15, 2022

tbouffard deleted the test/bump_jest_v28 branch November 15, 2022 14:09

tbouffard mentioned this pull request Nov 16, 2022

[TEST] Bump Jest dependencies to use version 29 #2352

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TEST] Bump Jest dependencies to use version 28 #2320

[TEST] Bump Jest dependencies to use version 28 #2320

Uh oh!

tbouffard commented Oct 25, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Oct 25, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Oct 25, 2022 •

edited

Loading

Uh oh!

Uh oh!

tbouffard commented Oct 25, 2022

Uh oh!

tbouffard commented Oct 25, 2022

Uh oh!

tbouffard commented Nov 6, 2022 •

edited

Loading

Uh oh!

csouchet Nov 15, 2022

Uh oh!

csouchet left a comment

Uh oh!

sonarqubecloud bot commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TEST] Bump Jest dependencies to use version 28 #2320

[TEST] Bump Jest dependencies to use version 28 #2320

Uh oh!

Conversation

tbouffard commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests done

Uh oh!

github-actions bot commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tbouffard commented Oct 25, 2022

Uh oh!

tbouffard commented Oct 25, 2022

Uh oh!

tbouffard commented Nov 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current issue with Performance tests compilation

Uh oh!

csouchet Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

csouchet left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tbouffard commented Oct 25, 2022 •

edited

Loading

github-actions bot commented Oct 25, 2022 •

edited

Loading

github-actions bot commented Oct 25, 2022 •

edited

Loading

tbouffard commented Nov 6, 2022 •

edited

Loading