Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Fix panning tests on webkit #1237

Merged
merged 13 commits into from
May 4, 2021
Merged

[TEST] Fix panning tests on webkit #1237

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9b0b629
Revert "Skip panning tests on webkit"
tbouffard Apr 16, 2021
0a6e1cd
Fix headless value for Playwright
csouchet Apr 28, 2021
5bfc49a
Fix pan on Webkit
csouchet Apr 30, 2021
be9b279
remove mouse pointer
csouchet Apr 30, 2021
80dff12
Fix threshold
csouchet Apr 30, 2021
e3adb1d
Add timeout on panning
csouchet Apr 30, 2021
278f502
Fix pan tests for Chromium & Firefox
csouchet Apr 30, 2021
242888a
Merge branch 'master' into infra/webkit_panning_tests
aibcmars May 3, 2021
2fe969f
thresholds
aibcmars May 3, 2021
136fbdc
thresholds
aibcmars May 3, 2021
26a2605
thresholds
aibcmars May 3, 2021
ef6ddd4
Revert "thresholds"
csouchet May 3, 2021
73ccd3c
revert HEADLESS type
csouchet May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions test/e2e/overlays.rendering.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,23 @@ class ImageSnapshotThresholds extends MultiBrowserImageSnapshotThresholds {
'overlays.start.flow.task.gateway',
{
linux: 0.001, // 0.09368089665046096%
windows: 0.0003, // 0.025623788967854555%
windows: 0.003, // 0.24558800934610941%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change anything for Chromium on windows. So it's weird to have to change it 🤔

Copy link
Member

@csouchet csouchet May 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aibcmars Can you verify if you have the same issue on the master branch ?
I updated the version of jest-image-snapshot this morning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes checking on master - I had like over 20 failures on local :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it is not passing on master as well
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I think we should fix that problem in another PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this should be done in a dedicated PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted all the Tresholds commits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested on windows 10 pro locally and don't get any e2e test errors with the original thresholds. This seems an environment issue.

},
],
[
'overlays.edges.message.flows.complex.paths',
{
linux: 0.0002, // 0.012292700871674445%
macos: 0.009, // 0.08719999889645891%
windows: 0.002, // 0.19835931612992574%
},
],
[
'overlays.edges.associations.complex.paths',
{
linux: 0.0003, // 0.02042994297090095% / 0.028687210421007858% / 0.022131767755118048%
macos: 0.002, // 0.013972840122933317%
windows: 0.002, // 0.19835931612992574%
},
],
[
Expand All @@ -60,6 +62,12 @@ class ImageSnapshotThresholds extends MultiBrowserImageSnapshotThresholds {
macos: 0.0002, // 0.010791806455801023%
},
],
[
'overlays.edges.sequence.flows.complex.paths',
{
windows: 0.002, // 0.18115730095212834%
},
],
]);
}

Expand All @@ -77,7 +85,6 @@ class ImageSnapshotThresholds extends MultiBrowserImageSnapshotThresholds {
{
linux: 0.0032, // 0.31451721857130854%
macos: 0.004, // 0.36700887485542344%
windows: 0.004, // 0.38563259095634184%
},
],
[
Expand Down Expand Up @@ -320,23 +327,23 @@ describe('Overlay style', () => {
{
linux: 0.00016, // 0.015068122418016028%
macos: 0.000006, // 0.0005215592635332555%
windows: 0.0001, // 0.009102728217447176%
windows: 0.002, // 0.16108430159252896%
},
],
[
'font',
{
linux: 0.0056, // 0.551258767924101%
macos: 0.000002, // 0.00013412837215343032%
windows: 0.0019, // 0.1837913233883048%
windows: 0.012, // 1.1286092563398964%
},
],
[
'stroke',
{
linux: 0.0018, // 0.17850987617574754%
macos: 0.000002, // 0.00011679796428909484%
windows: 0.00028, // 0.02743892318561869%
windows: 0.001, // 0.09036713671126684%
},
],
]);
Expand Down