refactor(demo): simplify the UseCase classes and how to set theme #564
Conversation
csouchet
added
depends on another PR ⚠️
csouchet
force-pushed
the
refactor/use_cases_in_demos
branch
3 times, most recently
from
9b3a1d4 to
81b19df
Compare
csouchet
removed
the
depends on another PR ⚠️
csouchet
force-pushed
the
refactor/use_cases_in_demos
branch
from
81b19df to
c5cea71
Compare
There was a problem hiding this comment.
ℹ️ I mainly check the features, less the code changes
Tested commit: c5cea71
✔️ monitoring
- with the UI use case and displayed information
- using query parameters https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/monitoring-all-process-instances/index.html?useCase=frequency&dataType=paths
✔️ prediction: all use cases are working
❌ hacktoberfest : default ko (others use cases are working: theme and year)
- default tab: not displayed and error in the console
- https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/hacktoberfest-custom-themes/index.html
- Firefox 118.0.2 (64 bits) on Ubuntu 20.04
14:34:59,117 Uncaught TypeError: this._bpmnVisualization is undefined
_displayVersionInfoInFooter https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/static/js/use-case.js:38
display https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/static/js/use-case.js:29
changeUseCase https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/hacktoberfest-custom-themes/js/index.js:19
oninput https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/c5cea71/demo/hacktoberfest-custom-themes/js/index.js:32
use-case.js:38:29
- Chrome 118.0.5993.70 (64 bits) on Ubuntu 20.04
use-case.js:38 Uncaught TypeError: Cannot read properties of undefined (reading 'getVersion')
at HacktoberfestUseCase._displayVersionInfoInFooter (use-case.js:38:53)
at HacktoberfestUseCase.display (use-case.js:29:14)
at changeUseCase (index.js:19:19)
at document.getElementById.onchange (index.js:37:5)
| @@ -1,17 +1,21 @@ | |||
| function buildUseCase(type, year, projectName) { | |||
| switch (type) { | |||
| function buildUseCase() { | |||
| if (themeElement.fontFamily) { | ||
| style[StyleIdentifiers.STYLE_FONTFAMILY] = themeElement.fontFamily; | ||
| } | ||
| if (themeElement.fontSize) { | ||
| style[StyleIdentifiers.STYLE_FONTSIZE] = themeElement.fontSize; | ||
| } |
There was a problem hiding this comment.
praise: more consistent with the management of other properties
There was a problem hiding this comment.
✔️ Validated remaining fix with https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/44cb8a1/demo/hacktoberfest-custom-themes/index.html
Live environment of examples
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/refactor/use_cases_in_demos/examples/index.html