refactor: simplify reset of StyleDefault #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
Introduce a shared function capable of resetting StyleDefault independently of the values that have been overridden.
tbouffard
force-pushed
the
refactor/theme_reset_StyleDefault
branch
from
b268079 to
56deae6
Compare
tbouffard
commented
Jun 12, 2023
tbouffard
commented
Jun 12, 2023
Comment on lines
+3
to
+5
| for (let key of Object.keys(bpmnvisu.StyleDefault)) { | ||
| bpmnvisu.StyleDefault[key] = originalStyleDefault[key]; | ||
| } |
There was a problem hiding this comment.
thought: this is the only implementation I've managed to get to work.
For example, the following has no effect. For example, the following has no effect. There's probably a good reason for this, but I haven't looked into it, because I've found another solution.
bpmnvisu.StyleDefault = { ...bpmnvisu.StyleDefault };
There was a problem hiding this comment.
It's normal to have no effect, if we set a variable with its own value 😄
There was a problem hiding this comment.
Well, I put the wrong code snippet 😸 , I meant
bpmnvisu.StyleDefault = { ...originalStyleDefault };
csouchet
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a shared function capable of resetting
StyleDefaultindependently of the values that have been overridden.This simplifies the code: it is no longer necessary to save and then manually restore the values that are modified in each example.
Live environment of examples
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/ba1eccd/examples/index.html
Previous urls
Notes
Also created to test that the new StyleDefault implementation is still working. See process-analytics/bpmn-visualization-js#2728