Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable diagram navigation in the "Overlays" demo #135

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Oct 3, 2023

The BPMN navigation doesn't remove the style applied externally from mxGraph (to hide the overlays) by a call to OverlaysPlugin.setVisible
The demo now enables the diagram navigation (with both Mouse event and buttons) to highlight the feature.

Closes #63

@tbouffard tbouffard added the enhancement New feature or request label Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

♻️ PR Preview 5ca121c has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard force-pushed the feat/63_demo_overlays_enable_navigation branch from a956d57 to 5ca121c Compare October 4, 2023 09:05
@tbouffard tbouffard marked this pull request as ready for review October 4, 2023 09:06
@tbouffard tbouffard requested a review from csouchet October 4, 2023 09:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit 5349a09 into main Oct 4, 2023
@tbouffard tbouffard deleted the feat/63_demo_overlays_enable_navigation branch October 4, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Enable the diagram navigation in the "overlays" demo
2 participants