Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use bpmn-visualization 0.39.0 as the minimum version required #109

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 4, 2023

Versions of bpmn-visualization prior to 0.39.0 did not support ESM in Node.js projects. They required the package.json file of bpmn-visualization to be patched in order to run tests.
bpmn-visualization@0.39.0 fixes this problem, so the patch can be removed.

closes #97
relates to #100

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

♻️ PR Preview fe48732 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard changed the title chore: use bpmn-visualization 0.39.0 as minimum required version chore: use bpmn-visualization 0.39.0 as the minimum version required Sep 4, 2023
@tbouffard tbouffard marked this pull request as ready for review September 4, 2023 11:31
@tbouffard tbouffard merged commit 3386dce into main Sep 4, 2023
@tbouffard tbouffard deleted the chore/97_bump_bpmn-visualization_0.39.0 branch September 4, 2023 11:32
@tbouffard tbouffard changed the title chore: use bpmn-visualization 0.39.0 as the minimum version required chore: use bpmn-visualization 0.39.0 as peer dependency Sep 4, 2023
@tbouffard tbouffard changed the title chore: use bpmn-visualization 0.39.0 as peer dependency chore: use bpmn-visualization 0.39.0 as the minimum version required Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] Remove the patch of the bpmn-visualization package.json when version 0.39.0 is available
1 participant