Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: use generic type when getting a plugin #106

Merged
merged 8 commits into from
Sep 4, 2023
Merged

feat!: use generic type when getting a plugin #106

merged 8 commits into from
Sep 4, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 31, 2023 •
edited by tbouffard
Loading

Avoid to have to cast the plugin type after getting it. It simplify the code reading.
It's still possible to not cast the plugin type, but now, the default type is Plugin and not unknown.

BREAKING CHANGE: BpmnVisualization.getPlugin now returns Plugin instead of unknown.

@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first enhancement New feature or request labels Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

♻️ PR Preview 50e595c has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard mentioned this pull request Aug 31, 2023
Merged
@csouchet csouchet force-pushed the use_generic_type_to_get_plugin branch 2 times, most recently from 420166c to 73a2c50 Compare August 31, 2023 15:20
@csouchet csouchet force-pushed the use_generic_type_to_get_plugin branch from 88e02ce to 250b4ef Compare September 4, 2023 07:22
@csouchet csouchet marked this pull request as ready for review September 4, 2023 07:23
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 4, 2023
@csouchet csouchet requested a review from tbouffard September 4, 2023 08:45
@tbouffard tbouffard changed the title feat: use generic type when getting a plugin feat!: use generic type when getting a plugin Sep 4, 2023
@tbouffard
Copy link
Member

Put in draft as we need to merge #107 first.
I am also going to update the code of the demo with the new syntax.

@tbouffard tbouffard marked this pull request as draft September 4, 2023 10:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard marked this pull request as ready for review September 4, 2023 13:19
@tbouffard tbouffard merged commit d772f32 into main Sep 4, 2023
@tbouffard tbouffard deleted the use_generic_type_to_get_plugin branch September 4, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard Awaiting requested review from tbouffard

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard