feat: prevent multiple plugins with the same ID from loading #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when loading such plugins, only the latest declared one was registered. This was done silently and consumers have no way to be aware of the problem. This is not possible anymore. An error is now thrown at plugin instantiation and the error message contains the duplicated id.
|
Kudos, SonarCloud Quality Gate passed!
|
|
♻️ PR Preview 1d94ebf has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when loading such plugins, only the latest declared one was registered. This was done silently and consumers have no way to be aware of the problem. This is not possible anymore. An error is now thrown at plugin instantiation and the error message contains the duplicated id.
closes #64